Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(jest-worker): support passing through ResourceLimits to worker #10335

Merged
merged 2 commits into from
Jul 30, 2020
Merged

feat(jest-worker): support passing through ResourceLimits to worker #10335

merged 2 commits into from
Jul 30, 2020

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Jul 29, 2020 •
edited
Loading

Summary

In the same way we allow passing forkOptions to child_process.

https://nodejs.org/api/worker_threads.html#worker_threads_new_worker_filename_options

Test plan

Green CI

@SimenB SimenB requested review from rickhanlonii and jeysal July 29, 2020 11:22
rickhanlonii
rickhanlonii approved these changes Jul 29, 2020
View reviewed changes
Copy link
Member

@rickhanlonii rickhanlonii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SimenB SimenB merged commit c7b1834 into jestjs:master Jul 30, 2020
@SimenB SimenB deleted the worker-resource-limits branch July 30, 2020 08:50
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rickhanlonii rickhanlonii rickhanlonii approved these changes

@jeysal jeysal Awaiting requested review from jeysal

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SimenB @rickhanlonii @facebook-github-bot